Incorporate changes from the original react-meteor-data package #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [@babel/runtime-corejs3](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime-corejs3) from 7.14.7 to 7.26.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-runtime-corejs3) --- updated-dependencies: - dependency-name: "@babel/runtime-corejs3" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…kages/react-meteor-data/babel/runtime-corejs3-7.26.10 chore(deps): bump @babel/runtime-corejs3 from 7.14.7 to 7.26.10 in /packages/react-meteor-data
Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.14.6 to 7.26.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-runtime) --- updated-dependencies: - dependency-name: "@babel/runtime" dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
…kages/react-meteor-data/babel/runtime-7.26.10 chore(deps): bump @babel/runtime from 7.14.6 to 7.26.10 in /packages/react-meteor-data
# Conflicts: # packages/react-meteor-data/package.js
Recover tests for latest 3.x
CI support (GA runner)
Bumps [ws](https://github.com/websockets/ws) to 8.18.1 and updates ancestor dependency [puppeteer](https://github.com/puppeteer/puppeteer). These dependencies need to be updated together. Updates `ws` from 8.13.0 to 8.18.1 - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@8.13.0...8.18.1) Updates `puppeteer` from 19.11.1 to 24.4.0 - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/CHANGELOG.md) - [Commits](puppeteer/puppeteer@puppeteer-v19.11.1...puppeteer-v24.4.0) --- updated-dependencies: - dependency-name: ws dependency-type: indirect - dependency-name: puppeteer dependency-type: direct:development ... Signed-off-by: dependabot[bot] <[email protected]>
Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.20.1 to 7.26.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-runtime) --- updated-dependencies: - dependency-name: "@babel/runtime" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]>
…ts/react-meteor-data-harness/babel/runtime-7.26.10 chore(deps): bump @babel/runtime from 7.20.1 to 7.26.10 in /tests/react-meteor-data-harness
…ts/react-meteor-accounts-harness/multi-5db6cdc4aa chore(deps): bump ws and puppeteer in /tests/react-meteor-accounts-harness
Ensure compatibility with latest React
…usefind # Conflicts: # packages/react-meteor-data/useFind.ts
Fix concurrency issue with useFind (Contribution)
Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.14.0 to 7.27.0. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.27.0/packages/babel-runtime) --- updated-dependencies: - dependency-name: "@babel/runtime" dependency-version: 7.27.0 dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]>
In strict mode (development only), useEffect may run 1-2 times. Throwing a promise outside can cause premature cleanup of subscriptions and cachedSubscription before unmount. To avoid this, check the timeout to ensure cleanup only occurs after unmount.
…el/runtime-7.27.0 chore(deps): bump @babel/runtime from 7.14.0 to 7.27.0
… server side and improved performance 1. On the server, useEffect doesn't run, so cached find data isn't cleared. Even after database updates, stale data is returned on subsequent requests. 2. useFindSuspense can't run on the client (non-reactive data makes it pointless), so the useEffect part was removed. 3. lodash.remove is no longer in use and can be removed. 4. According to 7d45b72, the package-lock.json file can be deleted. This PR depends on meteor#429
…ache invalidation
Accept contributions around suspense and performance on useFind and useSubscribe hooks
In the client-side implementation of suspense/useFind, useFindClient is used. PR meteor#433 introduced useSyncEffect. Nevertheless, when used in Strict Mode and with Suspense, the useSyncEffect implementation results in non-trivial and hard-to-predict issues. As a result, the Suspense-enabled useFindSuspenseClient will no longer reference useFindClient and will instead be a standalone implementation (derived from the last stable version of useFindClient).
fix: meteor#443 useSyncEffect Breaks useFind Reactivity Under Suspense
Fix TS syntax to favor swc compilation
perf(suspense): optimize handling of multiple suspense/useSubscribe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, the @meteor-vite/react-meteor-data is not working anymore.
I have incorporated the newest changes from the original Atmosphere package.
With that I still have a problem, because the package is using
lodash.isequalonce, which vite seems to have problems with. I replaced the outdated lodash.isequal with fast-equals, which seems to work, although I am not sure if strictDeepEqual is the correct replacement.I have also created PR on the original library:
meteor#451