-
Notifications
You must be signed in to change notification settings - Fork 0
[Refactor/#132] PlanService 책임 분리 리펙토링 #133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmihye
approved these changes
Jul 28, 2025
Member
mmihye
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
책임에 따리 분리되어 더 코드가 보기 편해진거같네요!!
수고하셨습니다 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚩 관련 이슈
📋 구현 기능 명세
📌 PR Point
PlanService에 모든 로직이 구현되어있는 것을 기능과 로직에 맞게 패키지 및 클래스 분리하여 SRP를 최대한 지키도록 리펙토링하였습니다.
S3UrlUtil 클래스 생성하여, S3 폴더명 생성 메소드 분리
어떤 부분에 리뷰어가 집중해야 하는지
최대한 책임 분리 하도록 리펙토링 하였는데, 부족한 부분이 있는지 확인해주시면 감사하겠습니당