[feat/#317] 마이노트 - 상세 - 체크리스트 조회 API #332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
essaysir
reviewed
Apr 7, 2025
| .answerType(entity.getQuestionId().getAnswerType()) | ||
| .build()) | ||
| .collect(Collectors.toList()); | ||
| } |
Contributor
There was a problem hiding this comment.
해당 부분에서 ChecklistAnswerResponseDTO 에서 정적 메서드를 만들어서 dto 로 변환을 로직을 넣으면 코드가 한눈에 보기가 좋아지고, 관심사도 정확히 분리될 거 같아서 더 좋지 않을 까 하는 의견이 있습니다.!
List<ChecklistAnswer> answerList = checklistAnswerRepository.findChecklistAnswerByLimjangId(limjang);
return ChecklistAnswerResponseDTO.fromEntityList(answerList);
Contributor
There was a problem hiding this comment.
저두 동의합니다 그리구 자바 16부터 .collect(Collectors.toList()); -> toList() 로 대체 가능한데 저희가 쓰는거 17이라 고려해보시면 조을 것 같아요!!
Contributor
There was a problem hiding this comment.
이 객체에서는 repository 같이 엔티티만 리턴하고 서비스나 DTO에서 가공하는건 어떨까요?? Limjang도 서비스에서 NoteFinder(LimjangFinder)에서 찾으면 더 좋을 것 같아요
| private final LimjangRepository limjangRepository; | ||
|
|
||
| public List<ChecklistAnswerResponseDTO.AnswerDto> findByLimjangId(Long limjangId) { | ||
| Limjang limjang = limjangRepository.findById(limjangId) |
Contributor
There was a problem hiding this comment.
임장찾을 때 deleted 필드가 false인 것으로 찾아주셔야할 것 같습니다!! 현재 softdelete 되는 형태라 삭제된 임장들도 다 찾아질 것 같습니다
| .answerType(entity.getQuestionId().getAnswerType()) | ||
| .build()) | ||
| .collect(Collectors.toList()); | ||
| } |
Contributor
There was a problem hiding this comment.
이 객체에서는 repository 같이 엔티티만 리턴하고 서비스나 DTO에서 가공하는건 어떨까요?? Limjang도 서비스에서 NoteFinder(LimjangFinder)에서 찾으면 더 좋을 것 같아요
PicturePark1101
pushed a commit
that referenced
this pull request
Jun 1, 2025
[feat/#317] 마이노트 - 상세 - 체크리스트 조회 API
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
작업내용
상세설명_ & 캡쳐
스웨거 통해서 테스팅한 결과입니다~!
Finder 사용하는 로직으로 변경했습니다!