Skip to content

[feat/#318] 닉네임 중복여부 API 구현#338

Merged
essaysir merged 4 commits intodevfrom
feat/#331
Apr 12, 2025
Merged

[feat/#318] 닉네임 중복여부 API 구현#338
essaysir merged 4 commits intodevfrom
feat/#331

Conversation

@essaysir
Copy link
Copy Markdown
Contributor

@essaysir essaysir commented Apr 8, 2025

작업내용

  • 회원가입 전 닉네임 중복 여부를 물어보는 API 구현 완료

상세설명_ & 캡쳐

  • 회원가입 전 진행하므로, 해당 api 는 권한 허용
.requestMatchers(
						AntPathRequestMatcher.antMatcher("/api/members/nickname/exists"),
						AntPathRequestMatcher.antMatcher("/h2-console/**")
					).permitAll()

essaysir added 2 commits April 8, 2025 19:22
- 해당 api는 권한 체크하지 않도록 SecurityConfig 수정
- MemberFixture 를 간단하게 구현, 추후에 리팩토링 필요
@essaysir essaysir requested review from PicturePark1101, hyeonahhh and yeon015 and removed request for yeon015 April 8, 2025 10:27
@essaysir essaysir self-assigned this Apr 8, 2025
@essaysir essaysir added the ✨ feature 기능 추가 label Apr 8, 2025

//prod아닐때
if (!isProd) {
return web -> web.ignoring()
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

오늘도 테스트 코드 잘봤습니다!! 이부분 따로 list로 만들어서 관리해도 좋을 것 같다는 의견 내봅니다

    private static final String[] authWhiteList = {"/api/v2", ..생략};
    ...생략

.requestMatchers(authWhiteList);

- 공통 URL과 개발 환경 전용 URL을 분리하여 코드 가독성 및 유지보수성 향상
@essaysir essaysir merged commit d028ecc into dev Apr 12, 2025
1 check passed
@essaysir essaysir deleted the feat/#331 branch April 21, 2025 12:52
PicturePark1101 pushed a commit that referenced this pull request Jun 1, 2025
[feat/#318] 닉네임 중복여부 API 구현
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

✨ feature 기능 추가

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants