Repository navigation
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #48 +/- ##
==========================================
+ Coverage 46.35% 47.37% +1.01%
==========================================
Files 17 17
Lines 2550 2550
==========================================
+ Hits 1182 1208 +26
+ Misses 1368 1342 -26 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
jamesrafe
force-pushed
the
fix/promote-bintable-scaling
branch
from
July 31, 2026 14:43
7366562 to
26b984f
Compare
jamesrafe
force-pushed
the
fix/promote-bintable-scaling
branch
from
July 31, 2026 14:46
26b984f to
5a72366
Compare
barrettp
requested changes
Aug 6, 2026
barrettp
left a comment
Member
There was a problem hiding this comment.
- Instead of an array of
Tuples, the data can be aTupleof arrays, which is simpler, - The test needs to ensure that the element type of the array is the smallest useable type, e.g., Float32, not just Float64. Arrays can be very large, so the returned array type needs to be the appropriate type. It is not clear that
muladd()ensures the best type is returned.
jamesrafe
marked this pull request as ready for review
August 13, 2026 19:02
Author
|
Hi @barrettp , I changed the fixture to a tuple of column arrays and added explicit eltype checks. The tests now verify that results remain Float32 when sufficient, while using Float64 for large TZERO. |
Member
|
PR #50 likely supersedes this patch. Without a description of the problem, it cannot be directly determined. Closing for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.