Skip to content

fix: preserve precision when scaling binary tables - #48

Closed
jamesrafe wants to merge 3 commits into
mainfrom
fix/promote-bintable-scaling
Closed

jamesrafe wants to merge 3 commits into
mainfrom
fix/promote-bintable-scaling

Conversation

@jamesrafe

Copy link
Copy Markdown

No description provided.

@codecov

codecov Bot commented Jul 31, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 47.37%. Comparing base (870e4ee) to head (0e5a427).

Files with missing lines Patch % Lines
src/hdu/bintable.jl 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #48      +/-   ##
==========================================
+ Coverage   46.35%   47.37%   +1.01%     
==========================================
  Files          17       17              
  Lines        2550     2550              
==========================================
+ Hits         1182     1208      +26     
+ Misses       1368     1342      -26     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jamesrafe
jamesrafe force-pushed the fix/promote-bintable-scaling branch from 7366562 to 26b984f Compare July 31, 2026 14:43
@jamesrafe
jamesrafe force-pushed the fix/promote-bintable-scaling branch from 26b984f to 5a72366 Compare July 31, 2026 14:46

@barrettp barrettp left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Instead of an array of Tuples, the data can be a Tuple of arrays, which is simpler,
  2. The test needs to ensure that the element type of the array is the smallest useable type, e.g., Float32, not just Float64. Arrays can be very large, so the returned array type needs to be the appropriate type. It is not clear that muladd() ensures the best type is returned.

@jamesrafe
jamesrafe marked this pull request as ready for review August 13, 2026 19:02
@jamesrafe

Copy link
Copy Markdown
Author

Hi @barrettp , I changed the fixture to a tuple of column arrays and added explicit eltype checks. The tests now verify that results remain Float32 when sufficient, while using Float64 for large TZERO.

@barrettp

barrettp commented Oct 2, 2026

Copy link
Copy Markdown
Member

PR #50 likely supersedes this patch. Without a description of the problem, it cannot be directly determined. Closing for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants