Skip to content

Phases 383-386: wrongly-typed and junk arguments raise ordinary errors (write_table data, query verbs, TaQL functions/operators/aggregates) - #123

Merged
barrettp merged 5 commits into
mainfrom
phase383-386-argument-types
Oct 10, 2026
Merged

barrettp merged 5 commits into
mainfrom
phase383-386-argument-types

Conversation

@barrettp

Copy link
Copy Markdown
Member

Summary

Robustness fuzz sweeps, each turning bare `MethodError`/`TypeError`/`BoundsError` failures into ordinary `ArgumentError`s that name the offending argument:

  • 383 — junk column data given to `write_table` (vector columns only, scalar/array cells, tiled managers refuse scalar/String columns, `shapes=` only for array columns).
  • 384 — wrongly-typed names/expressions/collections given to `query`/`groupby`/`join`/`update!`/`delete!`/`insert!` (`_tql_name`, `_tql_check_cond`); a string into a numeric column (and a number into a String column) is refused at assignment.
  • 385 — TaQL-lite functions given operands of a type they do not handle (`_tql_call`); integer `fmod(x, 0)` = x like real TaQL.
  • 386 — operators (`_bcast`), group aggregates, `LIKE`/`~`, `mscal.stokes` on a non-array, `meas.` direction arguments, and `AssertionError`s from function implementations.
  • Follow-up: no live cross-check of integer `fmod(x, 0)` (undefined behaviour in casacore, SIGFPE on x86-64 — caught by the Docker run).

Test plan

  • Full local suite: 10649 passed (ARM64; CASA-dependent cross-checks skipped, DMG not mounted)
  • Full suite in linux/amd64 Docker (julia 1.10): 10669 passed
  • Seeded regression tests added for each phase

🤖 Generated with Claude Code

barrettp and others added 5 commits October 9, 2026 17:47
…rs (vector columns, scalar/array cells, tiled managers, shapes=)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…rrors; string/number mismatch refused at cell assignment

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…umentErrors; integer fmod(x, 0) = x

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…rongly-typed operands raise ArgumentErrors

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
…ined behaviour in casacore, SIGFPE on x86-64)

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@barrettp
barrettp merged commit 2029ce4 into main Oct 10, 2026
5 checks passed
@barrettp
barrettp deleted the phase383-386-argument-types branch October 10, 2026 13:07
@codecov

codecov Bot commented Oct 10, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.26027% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.09%. Comparing base (65b1e5e) to head (9580081).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
src/taql/functions.jl 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #123      +/-   ##
==========================================
+ Coverage   96.04%   96.09%   +0.05%     
==========================================
  Files          52       52              
  Lines       10632    10676      +44     
==========================================
+ Hits        10211    10259      +48     
+ Misses        421      417       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant