Skip to content

Add the passes of XSTAR's npass - #69

Merged
barrettp merged 1 commit into
mainfrom
passes
Oct 9, 2026
Merged

barrettp merged 1 commit into
mainfrom
passes

Conversation

@barrettp

@barrettp barrettp commented Oct 9, 2026

Copy link
Copy Markdown
Member

passes=3 (odd) on march_zones/slab_model: an even pass marches from the outer edge inwards at the temperatures of the first pass to collect the optical depths of the lines and edges beyond each zone; the odd passes use them as the outward depths of the escape probabilities.

On the thick slab the He II fractions change by 2.5% (first zone) to 0.2%, and follow an npass=3 run of XSTAR (new reference xout_abund1_npass3.fits) to 0.15% in the change. Tested only for the ion fractions at fixed temperature. Full suite passes on Julia 1.13 (987 tests).

🤖 Generated with Claude Code

An even pass marches back from the outer edge at the temperatures of the
first pass and gives the optical depths of the lines and edges beyond each
zone; the odd passes use them as the outward depths of the escape
probabilities. Checked against an npass=3 run of XSTAR.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@barrettp
barrettp merged commit bd10bbb into main Oct 9, 2026
5 checks passed
@barrettp
barrettp deleted the passes branch October 9, 2026 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant