Skip to content

Conversation

jlumpe
Copy link
Collaborator

@jlumpe jlumpe commented May 27, 2022

Restoring the old printnode method for potentially large collections (fAbstractArray and AbstractDict), which just prints the type.

@codecov-commenter
Copy link

codecov-commenter commented May 27, 2022

Codecov Report

Merging #101 (13f50d5) into master (5d3c880) will decrease coverage by 0.13%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #101      +/-   ##
==========================================
- Coverage   52.01%   51.87%   -0.14%     
==========================================
  Files           7        7              
  Lines         373      374       +1     
==========================================
  Hits          194      194              
- Misses        179      180       +1     
Impacted Files Coverage Δ
src/builtins.jl 75.00% <0.00%> (-10.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d3c880...13f50d5. Read the comment docs.

@ExpandingMan
Copy link
Contributor

This seems a bit aggressive, there is a huge class of cases in which this will make the display much worse...

Perhaps our real problem here is that we use print rather than some version of show, the latter of which is compact in at least some contexts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants