Skip to content

Reuse handle remapping slots in MutableBinaryHeap #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Reuse handle remapping slots in MutableBinaryHeap #807

wants to merge 1 commit into from

Conversation

ancapdev
Copy link
Contributor

Fixes #745

@ancapdev
Copy link
Contributor Author

Considered changing handle tables to Int32, which if we're comfortable limiting the collection to 2 billion entries could save a lot of space (node map, node map free list, and node back handle). Could be done separately or here, happy to contribute either. Thoughts?

@ancapdev
Copy link
Contributor Author

ancapdev commented Jun 4, 2022

Hi, any chance for a review and merge of this, please? Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node_map in MutableBinaryHeap grows indefinitely
1 participant
@ancapdev