Skip to content

Implement eltype for list #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Implement eltype for list #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6e68d3e
Implement eltype for list
saolof Jun 14, 2021
1bea603
Also added Base.IteratorEltype and Base.IteratorSize
saolof Jun 14, 2021
fb3bb25
Added in tests
saolof Jun 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions src/PersistentList.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,11 @@ Base.isequal(l1::PersistentList, l2::PersistentList) =
==(l1::PersistentList, l2::PersistentList) =
head(l1) == head(l2) && tail(l1) == tail(l2)

Base.eltype(::Type{<:AbstractList{T}}) where {T} = T
Base.IteratorEltype(::Type{<:AbstractList{T}}) where {T} = Base.HasEltype()
Base.IteratorSize(::Type{<:EmptyList}) = Base.HasLength()
Base.IteratorSize(::Type{<:PersistentList}) = Base.HasLength()

Base.iterate(l::AbstractList) = iterate(l, l)
Base.iterate(::AbstractList, ::EmptyList) = nothing
Base.iterate(::AbstractList, l::PersistentList) = (head(l), tail(l))
Expand Down
16 changes: 16 additions & 0 deletions test/PersistentListTest.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,22 @@ using FunctionalCollections
using Test

@testset "Persistent Lists" begin
@testset "iterator interface" begin
l1 = plist([1,2,3])
l2 = plist(Int[])
T1 = typeof(l1)
T2 = typeof(l2)

@test Base.IteratorSize(T1) == Base.HasLength()
@test Base.IteratorSize(T2) == Base.HasLength()
@test Base.IteratorEltype(T1) == Base.HasEltype()
@test Base.IteratorEltype(T2) == Base.HasEltype()
@test Base.eltype(T1) == Int
@test Base.eltype(T2) == Int

@test Base.eltype(typeof(collect(l1))) == Int
@test Base.eltype(typeof(collect(l2))) == Int
end

@testset "length" begin
@test length(PersistentList([1])) == 1
Expand Down