add sliding_window_maxima
#126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature addition: add iterator whose elements are maxima of a sliding window over an original iterator.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
==========================================
+ Coverage 90.72% 91.96% +1.23%
==========================================
Files 1 1
Lines 399 473 +74
==========================================
+ Hits 362 435 +73
- Misses 37 38 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
why does this have some very aggressive compiler directives thoughout it? these are going to require careful hand checking. |
This comment was marked as outdated.
This comment was marked as outdated.
nsajko
commented
Jul 9, 2025
Should mean better type stability for users.
They're not necessary now that the iterator type does not depend on the window size.
|
bump |
|
bump |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature addition: add iterator whose elements are maxima of a sliding window over an original iterator.