Skip to content

Conversation

adienes
Copy link
Member

@adienes adienes commented Sep 6, 2025

closes #48916 as suggested by @oscardssmith

I believe the more consistent behavior here would be for isless to error when comparing two Arrays a and b where eachindex(a,b)∉(eachindex(a), eachindex(b)) (similarly to how it works with Complex numbers or other collections like Dict that don't have an ordering.

@adienes adienes added bugfix This change fixes an existing bug collections Data structures holding multiple items, e.g. sets equality Issues relating to equality relations: ==, ===, isequal labels Sep 6, 2025
@nsajko nsajko added the arrays [a, r, r, a, y, s] label Sep 7, 2025
@adienes adienes changed the title max vector cmp match axes make vector cmp match axes Sep 7, 2025
@adienes

This comment was marked as outdated.

@nanosoldier

This comment was marked as outdated.

@adienes

This comment was marked as outdated.

@nanosoldier

This comment was marked as outdated.

@adienes

This comment was marked as outdated.

@adienes
Copy link
Member Author

adienes commented Sep 11, 2025

very tangential, but it's a shame to have to use exceptions here. partial orders seem like the perfect use case for a Some-or-nothing API

@adienes adienes reopened this Sep 12, 2025
@adienes
Copy link
Member Author

adienes commented Sep 12, 2025

@nanosoldier runtests()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arrays [a, r, r, a, y, s] bugfix This change fixes an existing bug collections Data structures holding multiple items, e.g. sets equality Issues relating to equality relations: ==, ===, isequal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lexicographic order for AbstractVector is inconsistent
3 participants