Skip to content

Conversation

JeffBezanson
Copy link
Member

This is to see how this change affects 1.12 PkgEval. Note we do not expect 100% compatibility for this, because number of allocations is implementation-dependent and not part of the API. Here I want to (1) restore the scope behavior for complex expressions, (2) try to avoid spurious allocations from call sites, and (3) failing that, make the behavior more predictable so tests can be updated more easily if they break.

@nanosoldier runtests(ALL, vs = ":release-1.12")

@JeffBezanson JeffBezanson added the DO NOT MERGE Do not merge this PR! label Sep 10, 2025
@DilumAluthge DilumAluthge marked this pull request as draft September 10, 2025 23:58
Also add `@constprop :none` and `@noinline` to prevent the measuring code from
interfering with the subject code.

Fixes #58780

(cherry picked from commit 23633c2)
@JeffBezanson
Copy link
Member Author

@nanosoldier runtests(ALL, vs = ":release-1.12")

@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Report summary

❗ Packages that crashed

3 packages crashed only on the current version.

  • The process was aborted: 1 packages
  • An internal error was encountered: 2 packages

51 packages crashed on the previous version too.

✖ Packages that failed

100 packages failed only on the current version.

  • Package fails to precompile: 13 packages
  • Illegal method overwrites during precompilation: 1 packages
  • Package has test failures: 2 packages
  • Package tests unexpectedly errored: 55 packages
  • Tests became inactive: 1 packages
  • Test duration exceeded the time limit: 28 packages

3610 packages failed on the previous version too.

✔ Packages that passed tests

44 packages passed tests only on the current version.

  • Other: 44 packages

5773 packages passed tests on the previous version too.

➖ Packages that were skipped altogether

1358 packages were skipped on the previous version too.

@nanosoldier
Copy link
Collaborator

The package evaluation job you requested has completed - possible new issues were detected.
The full report is available.

Report summary

❗ Packages that crashed

4 packages crashed only on the current version.

  • The process was aborted: 1 packages
  • Invalid LLVM IR was generated: 2 packages
  • GC corruption was detected: 1 packages

49 packages crashed on the previous version too.

✖ Packages that failed

36 packages failed only on the current version.

  • Package has test failures: 4 packages
  • Package tests unexpectedly errored: 5 packages
  • Tests became inactive: 3 packages
  • Test duration exceeded the time limit: 24 packages

3589 packages failed on the previous version too.

✔ Packages that passed tests

50 packages passed tests only on the current version.

  • Other: 50 packages

5860 packages passed tests on the previous version too.

➖ Packages that were skipped altogether

1359 packages were skipped on the previous version too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Do not merge this PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants