-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
CI: test buildkite branch to not run external stdlib test unless they are updated or on a release branch #59535
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
That seems ok, now let's test updating a |
Seems like we might have a bug somewhere? For Linux, we have several places where we split up "net" and "non-net" tests into two separate Buildkite jobs. The reasoning for this is that we want to run "non-net" under rr. We don't want to run "net" under rr, because it becomes unbearably slow to e.g. run Pkg tests under rr. I wonder if the mechanism that we use for splitting up "net" and "non-net" might be interacting badly with the new "skip external stdlibs" logic. |
Seems it didn't detect the |
If you run those same Git commands locally (the ones you're using to check for diff), do you get the result you expect? |
I'll have to add some debug stuff to the pipeline because it is possible the paths are not set up like I thought. |
Seems to work now. Perhaps ironically, the mistake was a main/master branch name confusion.
(Note Pkg not in the list). |
3a656c2
to
5149973
Compare
This happens when you do e.g. |
JuliaCI/julia-buildkite#483