Skip to content

Conversation

KristofferC
Copy link
Member

@KristofferC KristofferC added the DO NOT MERGE Do not merge this PR! label Sep 11, 2025
@DilumAluthge DilumAluthge marked this pull request as draft September 11, 2025 13:50
@KristofferC KristofferC changed the title testr buildkite branch to not run external stdlib test unless they are updated or on a release branch test buildkite branch to not run external stdlib test unless they are updated or on a release branch Sep 11, 2025
@KristofferC
Copy link
Member Author

EXTERNAL_STDLIBS_SKIPPED: ArgTools DelimitedFiles Distributed Downloads JuliaSyntaxHighlighting LazyArtifacts LibCURL LinearAlgebra NetworkOptions Pkg SHA SparseArrays Statistics StyledStrings SuiteSparse Tar

TESTS is: all --ci --skip ArgTools DelimitedFiles Distributed Downloads JuliaSyntaxHighlighting LazyArtifacts LibCURL LinearAlgebra NetworkOptions Pkg SHA SparseArrays Statistics StyledStrings SuiteSparse Tar

That seems ok, now let's test updating a .version file to see that that stdlib runs.

@DilumAluthge
Copy link
Member

┌ Warning: Not skipping tests: LinearAlgebra, SHA, StyledStrings, Pkg, SparseArrays, Distributed, JuliaSyntaxHighlighting, SuiteSparse, ArgTools, LazyArtifacts, NetworkOptions, Statistics, Tar, LibCURL, DelimitedFiles

Seems like we might have a bug somewhere?

For Linux, we have several places where we split up "net" and "non-net" tests into two separate Buildkite jobs. The reasoning for this is that we want to run "non-net" under rr. We don't want to run "net" under rr, because it becomes unbearably slow to e.g. run Pkg tests under rr.

I wonder if the mechanism that we use for splitting up "net" and "non-net" might be interacting badly with the new "skip external stdlibs" logic.

@KristofferC
Copy link
Member Author

EXTERNAL_STDLIBS_SKIPPED: ArgTools DelimitedFiles Distributed Downloads JuliaSyntaxHighlighting LazyArtifacts LibCURL LinearAlgebra NetworkOptions Pkg SHA SparseArrays Statistics StyledStrings SuiteSparse Tar

Seems it didn't detect the .version file change.

@DilumAluthge
Copy link
Member

If you run those same Git commands locally (the ones you're using to check for diff), do you get the result you expect?

@KristofferC
Copy link
Member Author

I'll have to add some debug stuff to the pipeline because it is possible the paths are not set up like I thought.

@KristofferC
Copy link
Member Author

KristofferC commented Sep 12, 2025

Seems to work now. Perhaps ironically, the mistake was a main/master branch name confusion.

EXTERNAL_STDLIBS_SKIPPED: ArgTools DelimitedFiles Distributed Downloads JuliaSyntaxHighlighting LazyArtifacts LibCURL LinearAlgebra NetworkOptions SHA SparseArrays Statistics StyledStrings SuiteSparse Tar

(Note Pkg not in the list).

@DilumAluthge DilumAluthge changed the title test buildkite branch to not run external stdlib test unless they are updated or on a release branch CI: test buildkite branch to not run external stdlib test unless they are updated or on a release branch Sep 12, 2025
@KristofferC
Copy link
Member Author

Seems like we might have a bug somewhere?

This happens when you do e.g. make test-Foo --skip Bar it will complain about Bar.

@DilumAluthge DilumAluthge deleted the kc/test_buildkite branch September 12, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Do not merge this PR!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants