-
-
Notifications
You must be signed in to change notification settings - Fork 465
WIP: add the 1.12 highlight blogpost #2351
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Once the build has completed, you can preview your PR at this URL: https://julialang.netlify.app/previews/PR2351/ in ~15 minutes |
|
||
**Example (before → after)** | ||
|
||
```llvm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that this line is causing CI to fail.
Could not find the language 'llvm', did you forget to load/include a language module?
/home/runner/work/www.julialang.org/www.julialang.org/_libs/highlight/highlight.min.js:234
;if(!N)throw H(o.replace("{}",e)),Error('Unknown language: "'+e+'"')
^
Error: Unknown language: "llvm"
at _ (/home/runner/work/www.julialang.org/www.julialang.org/_libs/highlight/highlight.min.js:234:35)
at Object.f [as highlight] (/home/runner/work/www.julialang.org/www.julialang.org/_libs/highlight/highlight.min.js:184:28)
at [eval]:1:2988
at Script.runInThisContext (node:vm:129:12)
at Object.runInThisContext (node:vm:307:38)
at node:internal/process/execution:79:19
at [eval]-wrapper:6:22
at evalScript (node:internal/process/execution:78:60)
at node:internal/main/eval_string:28:3
Co-authored-by: Zentrik <[email protected]>
9c6ac33
to
df36e73
Compare
Converting to draft while WIP. |
The |
The "Build and deploy" CI failure is real - the |
|
||
**Example (before → after)** | ||
|
||
```llvm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For now, how about we remove the llvm
and just format it as plain text. And then if we can figure out how to get llvm
syntax highlighting to work with Franklin.jl, then we can add it back?
```llvm | |
``` |
Happy for help, you can add new highlights or fill out the existing ones. I've started a bit.