Add kamenev for polytope approximations#4272
Open
maartenvd wants to merge 1 commit intoJuliaReach:masterfrom
Open
Add kamenev for polytope approximations#4272maartenvd wants to merge 1 commit intoJuliaReach:masterfrom
maartenvd wants to merge 1 commit intoJuliaReach:masterfrom
Conversation
schillic
approved these changes
Apr 25, 2026
Member
schillic
left a comment
schillic
left a comment
There was a problem hiding this comment.
Looks good to me, thanks! Two minor suggestions only (assuming that the tests pass).
Comment on lines
+13
to
+16
| @test inner2 isa VPolytope | ||
|
|
||
| outer2 = overapproximate(B, HPolytope, tol) | ||
| @test outer2 isa HPolytope |
Member
There was a problem hiding this comment.
Suggested change
| @test inner2 isa VPolytope | |
| outer2 = overapproximate(B, HPolytope, tol) | |
| @test outer2 isa HPolytope | |
| @test inner2 == inner | |
| outer2 = overapproximate(B, HPolytope, tol) | |
| @test outer2 == outer |
This should hold, right?
| inner_V = VPolytope(inner_V.vertices) | ||
| inner_H = convert(HPolytope,inner_V) # this isn't ideal. inner_H was still largely correct | ||
|
|
||
| outer = concretize(outer ∩ HalfSpace(worst_face.a,ρ(worst_face.a,S))) |
Member
There was a problem hiding this comment.
Suggested change
| outer = concretize(outer ∩ HalfSpace(worst_face.a,ρ(worst_face.a,S))) | |
| outer = intersection(outer, HalfSpace(worst_face.a,ρ(worst_face.a,S))) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned in #969 , a simple algorithm to approximate lazysets by a polytope.