Skip to content

Conversation

@tkf
Copy link
Contributor

@tkf tkf commented May 15, 2020

test/runtests.jl Outdated
@test_throws MethodError mean([])
@test_throws MethodError mean(skipmissing([]))
@test_throws ArgumentError mean((1 for i in 2:1))
if VERSION >= v"1.6"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This version bound has to be updated once JuliaLang/julia#35843 is merged.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's merged now! :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping :)

@tkf tkf marked this pull request as ready for review May 27, 2020 16:42
@nalimilan nalimilan merged commit 4069cd5 into JuliaStats:master May 27, 2020
@nalimilan
Copy link
Member

Thanks!

@tkf tkf deleted the empty-mean branch May 27, 2020 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants