Skip to content

Conversation

tmunzer-AIDE
Copy link
Collaborator

bring new API features to the TF Provider. Fix some issues.

- dhcp_conffig.ip6
- port_config.wan_ext_ip6
- port_config.wan_source_nat.nat6_pool
- dhcpd_config.fixed_biding.ip6
- port_usage.stp_disable
- port_usage.stp_required
- dhcp_conffig.ip6
- port_config.wan_ext_ip6
- port_config.wan_source_nat.nat6_pool
- dhcp_conffig.ip6
- port_config.wan_ext_ip6
- port_config.wan_source_nat.nat6_pool
- url_filtering_deny_msg
- port_usage.stp_disable
- port_usage.stp_required
- switch_matching.rules.stp_config
- port_usage.stp_disable
- port_usage.stp_required
- switch_matching.rules.stp_config
- juniper_srx
- juniper_srx.auto_upgrade
- ssr.proxy
- ssr.auto_upgrade
- ui_not_tracking
- vpn_options.enable_ipv6
- juniper_srx.auto_upgrade
- ssr.proxy
- ssr.auto_upgrade
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds new API features for v0.6.0: IPv6-related attributes (ip6, nat6_pool, wan_ext_ip6, enable_ipv6), STP configuration (stp_disable, stp_required, stp_config), auto-upgrade & proxy blocks for SSR and Juniper SRX, URL filtering deny message support, expanded NAC tag matching, and numerous schema/doc description refinements.

  • Introduces multiple optional IPv6 fields and STP-related attributes across gateway, network templates, and device profiles.
  • Adds SSR / Juniper SRX auto-upgrade & proxy mapping logic plus URL filtering denial message handling.
  • Expands schema but several generated type converters still wrongly require newly optional attributes (bugs).

Reviewed Changes

Copilot reviewed 116 out of 120 changed files in this pull request and generated no comments.

Show a summary per file
File Description
templates/guides/release_note_0.6.xx.md Adds 0.6.xx release notes (new features listing)
templates/guides/release_note_0.5.xx.md Clarifies previously listed fixes formatting
templates/guides/getting_started.md Adjusts example resource references and comments
internal/resource_upgrade_device/upgrade_device_resource_gen.go Expands upgrade status enum values
internal/resource_site_wlan/site_wlan_resource_gen.go Removes list size validator; enhances portal attribute descriptions
internal/resource_site_setting/terraform_to_sdk_ssr.go Adds SSR proxy & auto-upgrade TF→SDK translation (possible diag duplication)
internal/resource_site_setting/terraform_to_sdk_juniper_srx.go Adds SRX auto-upgrade TF→SDK translation
internal/resource_site_setting/terraform_to_sdk.go Wires new SRX/SSR conversions with context/diags
internal/resource_site_setting/sdk_to_terraform_ssr.go Adds SSR proxy & auto-upgrade SDK→TF mapping
internal/resource_site_setting/sdk_to_terraform_juniper_srx.go Adds SRX auto-upgrade SDK→TF mapping
internal/resource_site_networktemplate/terraform_to_sdk_switch_matching.go Adds STP config conversion logic
internal/resource_site_networktemplate/terraform_to_sdk_port_usage.go Adds stp_disable / stp_required handling
internal/resource_site_networktemplate/site_networktemplate_resource_gen.go Adds STP related schema attributes & descriptions
internal/resource_site_networktemplate/sdk_to_terraform_switch_matching.go Adds STP config SDK→TF mapping
internal/resource_site_networktemplate/sdk_to_terraform_port_usage.go Adds STP flags SDK→TF mapping
internal/resource_site_networktemplate/sdk_to_terraform_acl_tags.go Adjusts empty list handling for macs
internal/resource_org_wlan/org_wlan_resource_gen.go Mirrors WLAN portal description changes
internal/resource_org_setting/terraform_to_sdk_vpn_options.go Adds enable_ipv6 mapping
internal/resource_org_setting/terraform_to_sdk_ssr.go Adds SSR proxy/auto-upgrade TF→SDK (possible diag duplication)
internal/resource_org_setting/terraform_to_sdk_juniper_srx.go Adds SRX auto-upgrade TF→SDK
internal/resource_org_setting/terraform_to_sdk.go Wires new Juniper SRX, SSR, ui_no_tracking
internal/resource_org_setting/sdk_to_terraform_vpn_options.go Adds enable_ipv6 SDK→TF
internal/resource_org_setting/sdk_to_terraform_ssr.go Adds SSR proxy/auto-upgrade SDK→TF
internal/resource_org_setting/sdk_to_terraform_mist_nac.go Adjusts list null handling
internal/resource_org_setting/sdk_to_terraform_juniper_srx.go Adds SRX auto-upgrade SDK→TF
internal/resource_org_setting/sdk_to_terraform.go Adds JuniperSrx, UiNoTracking state mapping
internal/resource_org_service/org_service_resource_gen.go Adjusts import ordering & alias
internal/resource_org_rftemplate/sdk_to_terraform_bands.go Changes channel list null semantics
internal/resource_org_rftemplate/org_rftemplate_resource_gen.go Adds bandwidth value 0 (disabled) across bands
internal/resource_org_networktemplate/terraform_to_sdk_switch_matching.go Adds STP config conversion
internal/resource_org_networktemplate/terraform_to_sdk_port_usage.go Adds stp_disable / stp_required handling
internal/resource_org_networktemplate/sdk_to_terraform_switch_matching.go Adds STP config SDK→TF mapping
internal/resource_org_networktemplate/sdk_to_terraform_port_usage.go Adds STP flags SDK→TF mapping
internal/resource_org_networktemplate/sdk_to_terraform_acl_tags.go Adjusts empty list handling for macs
internal/resource_org_networktemplate/org_networktemplate_resource_gen.go Adds STP attributes and descriptions
internal/resource_org_network/terraform_to_sdk_vpn.go Renames exported VpnTerraformToSdk to unexported vpnTerraformToSdk
internal/resource_org_network/terraform_to_sdk_tenant.go Renames exported TenantTerraformToSdk to tenantTerraformToSdk
internal/resource_org_network/terraform_to_sdk_multicast.go Renames exported MulticastTerraformToSdk to multicastTerraformToSdk
internal/resource_org_network/terraform_to_sdk_internet_access.go Renames exported InternetAccessTerraformToSdk
internal/resource_org_network/terraform_to_sdk_internal_access.go Renames exported InternalAccessTerraformToSdk
internal/resource_org_network/terraform_to_sdk.go Updates calls to new unexported conversion funcs
internal/resource_org_network/sdk_to_terraform_vpn.go Renames exported VpnSdkToTerraform to vpnSdkToTerraform
internal/resource_org_network/sdk_to_terraform_tenant.go Renames exported TenantSdkToTerraform to tenantSdkToTerraform
internal/resource_org_network/sdk_to_terraform_internet_access.go Renames exported InternetAccessSdkToTerraform
internal/resource_org_network/sdk_to_terraform_internal_access.go Renames exported InternalAccessSdkToTerraform
internal/resource_org_network/sdk_to_terraform.go Updates references to renamed functions
internal/resource_org_nactag/org_nactag_resource_gen.go Expands match enums, updates redirect type text
internal/resource_org_gatewaytemplate/terraform_to_sdk_port_config.go Adds nat6_pool & wan_ext_ip6 handling
internal/resource_org_gatewaytemplate/terraform_to_sdk_networks.go Replaces prior IP networks converter with expanded version (includes IPv6 & NAT)
internal/resource_org_gatewaytemplate/terraform_to_sdk_dhcpd_config.go Adds ip6 for fixed bindings
internal/resource_org_gatewaytemplate/terraform_to_sdk.go Adds url_filtering_deny_msg mapping
internal/resource_org_gatewaytemplate/sdk_to_terraform_port_config.go Adds nat6_pool & wan_ext_ip6 SDK→TF
internal/resource_org_gatewaytemplate/sdk_to_terraform_networks.go Adds full network SDK→TF including IPv6 & NAT
internal/resource_org_gatewaytemplate/sdk_to_terraform_dchpd_config.go Adds ip6 to fixed bindings SDK→TF
internal/resource_org_gatewaytemplate/sdk_to_terraform.go Adds UrlFilteringDenyMsg state mapping
internal/resource_org_gatewaytemplate/org_gatewaytemplate_resource_gen.go Adds ip6 fields, wan_ext_ip6, nat6_pool, url_filtering_deny_msg; schema adjustments (introduces optional vs required mismatch bugs)
internal/resource_org_deviceprofile_gateway/terraform_to_sdk_port_config.go Adds nat6_pool & wan_ext_ip6 handling
internal/resource_org_deviceprofile_gateway/terraform_to_sdk_networks.go New network conversion with IPv6 & NAT
internal/resource_org_deviceprofile_gateway/terraform_to_sdk_dhcpd_config.go Adds ip6 to fixed bindings
internal/resource_org_deviceprofile_gateway/terraform_to_sdk.go Adds url_filtering_deny_msg mapping
internal/resource_org_deviceprofile_gateway/sdk_to_terraform_port_config.go Adds nat6_pool & wan_ext_ip6 SDK→TF
internal/resource_org_deviceprofile_gateway/sdk_to_terraform_networks.go Adds full network SDK→TF including IPv6 & NAT
internal/resource_org_deviceprofile_gateway/sdk_to_terraform_dchpd_config.go Adds ip6 to fixed bindings SDK→TF
internal/resource_org_deviceprofile_gateway/sdk_to_terraform.go Adds UrlFilteringDenyMsg state mapping
Comments suppressed due to low confidence (28)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@Copilot Copilot AI review requested due to automatic review settings October 16, 2025 14:49
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 118 out of 122 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (24)

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants