chore: bump stakers module from v1beta1 to v1 #246
Conversation
|
Warning Rate limit exceeded@troykessler has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 10 minutes and 59 seconds before requesting another review. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (4)
WalkthroughThis update transitions the stakers module from its beta release to a stable release by bumping version references from Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant TxHandler
participant StakersModule
participant EventLogger
User->>TxHandler: Submit MsgJoinPool with join details
TxHandler->>StakersModule: Validate and process join request
StakersModule-->>TxHandler: Return confirmation/result
TxHandler->>EventLogger: Emit join pool event
EventLogger-->>User: Send acknowledgment of transaction
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
proto/kyve/stakers/v1/tx.proto (1)
29-29: Address TODO comment about renaming MsgUpdateCommission.The TODO indicates a need to create v1 types and rename to MsgUpdatePoolCommission.
Would you like me to help implement the v1 types and rename the message as suggested in the TODO?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (10)
x/query/types/params.pb.gois excluded by!**/*.pb.gox/query/types/stakers.pb.gois excluded by!**/*.pb.gox/query/types/stakers.pb.gw.gois excluded by!**/*.pb.gw.gox/stakers/types/events.pb.gois excluded by!**/*.pb.gox/stakers/types/genesis.pb.gois excluded by!**/*.pb.gox/stakers/types/params.pb.gois excluded by!**/*.pb.gox/stakers/types/query.pb.gois excluded by!**/*.pb.gox/stakers/types/query.pb.gw.gois excluded by!**/*.pb.gw.gox/stakers/types/stakers.pb.gois excluded by!**/*.pb.gox/stakers/types/tx.pb.gois excluded by!**/*.pb.go
📒 Files selected for processing (12)
CHANGELOG.md(1 hunks)app/upgrades/v2_0/upgrade.go(1 hunks)docs/config.json(1 hunks)docs/static/openapi.yml(5 hunks)proto/kyve/query/v1/stakers.proto(6 hunks)proto/kyve/query/v1beta1/params.proto(2 hunks)proto/kyve/stakers/v1/events.proto(1 hunks)proto/kyve/stakers/v1/genesis.proto(1 hunks)proto/kyve/stakers/v1/params.proto(1 hunks)proto/kyve/stakers/v1/query.proto(1 hunks)proto/kyve/stakers/v1/stakers.proto(1 hunks)proto/kyve/stakers/v1/tx.proto(2 hunks)
✅ Files skipped from review due to trivial changes (3)
- app/upgrades/v2_0/upgrade.go
- proto/kyve/stakers/v1/stakers.proto
- proto/kyve/stakers/v1/params.proto
🧰 Additional context used
🪛 Buf (1.47.2)
proto/kyve/stakers/v1/events.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/kyve/stakers/v1/query.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
proto/kyve/stakers/v1/genesis.proto
5-5: import "gogoproto/gogo.proto": file does not exist
(COMPILE)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Summary
🔇 Additional comments (12)
docs/static/openapi.yml (5)
4220-4223: LGTM! Endpoint version updated correctly.The staker query endpoint has been properly updated to v1, maintaining consistency with the version bump objective.
4922-4925: LGTM! Endpoint version updated correctly.The stakers list endpoint has been properly updated to v1, maintaining consistency with the version bump objective.
5728-5731: LGTM! Endpoint version updated correctly.The stakers by pool endpoint has been properly updated to v1, maintaining consistency with the version bump objective.
6443-6446: LGTM! Endpoint version updated correctly.The stakers by pool count endpoint has been properly updated to v1, maintaining consistency with the version bump objective.
8824-8827: LGTM! Endpoint version updated correctly.The stakers params endpoint has been properly updated to v1, maintaining consistency with the version bump objective.
proto/kyve/stakers/v1/query.proto (1)
3-3: LGTM! Package and import paths correctly updated.The changes consistently update the package declaration, import paths, and HTTP endpoint from v1beta1 to v1.
Also applies to: 7-7, 15-15
proto/kyve/query/v1beta1/params.proto (1)
11-11: LGTM! Import path and field type correctly updated.The changes properly update the import path and field type to reference the new v1 package while maintaining the v1beta1 package for the query module.
Also applies to: 39-39
proto/kyve/stakers/v1/tx.proto (1)
3-3: LGTM! Package updated and new message properly structured.The new MsgJoinPool message follows protobuf best practices with proper field annotations and clear documentation.
Also applies to: 63-84
proto/kyve/stakers/v1/events.proto (1)
3-3: LGTM! Package, imports, and field types correctly updated.The changes consistently update the package declaration, import paths, and field types from v1beta1 to v1.
Also applies to: 6-7, 15-17
proto/kyve/query/v1/stakers.proto (1)
3-3:Details
❓ Verification inconclusive
Verify v1beta1.FullStaker references.
While the package and HTTP endpoints are updated to v1, the field types still reference
kyve.query.v1beta1.FullStaker. Please confirm if this is intentional or if these references should also be updated to v1.Also applies to: 16-16, 21-21, 26-26, 32-32, 71-71, 89-89, 105-105, 121-121
🏁 Script executed:
#!/bin/bash # Description: Check if FullStaker is defined in both v1beta1 and v1 packages # Search for FullStaker definition rg -A 5 "message FullStaker"Length of output: 374
Attention: Verify FullStaker Type Updates
The package and HTTP endpoints in
proto/kyve/query/v1/stakers.protohave been updated to v1, but the field types still referencekyve.query.v1beta1.FullStaker. A search confirms that theFullStakermessage is defined only inproto/kyve/query/v1beta1/query.proto, with no corresponding v1 definition present. Please verify whether the continued use of the v1beta1 reference is intentional or if these should be updated to align with the new v1 package. This review applies to the following code locations:
- Line 16
- Line 21
- Line 26
- Line 32
- Line 71
- Line 89
- Line 105
- Line 121
docs/config.json (1)
51-51: LGTM! Swagger URLs correctly updated for stakers module.The URLs have been properly updated from v1beta1 to v1, maintaining consistency with the stakers module version bump.
Also applies to: 57-57
CHANGELOG.md (1)
28-28: LGTM! Version bump properly documented in changelog.The change is correctly documented under the "Improvements" section, following the changelog format guidelines.
Summary by CodeRabbit
New Features
Improvements