Open
Conversation
chriscerie
force-pushed
the
fixes
branch
2 times, most recently
from
ae7555e to
7af2433
Compare
chriscerie
force-pushed
the
fixes
branch
3 times, most recently
from
dae8f5f to
251bc5b
Compare
chriscerie
commented
Oct 19, 2023
Comment on lines
-99
to
+228
| pretty_assertions::assert_eq!(PrettyString(&expected), PrettyString(stderr)); | ||
| pretty_assertions::assert_eq!( | ||
| PrettyString(&expected.replace("\r\n", "\n")), | ||
| PrettyString(&stderr.to_string().replace("\r\n", "\n")) | ||
| ); |
Collaborator
Author
There was a problem hiding this comment.
Without normalizing, this one specific lint fails. I'm confused why this wasn't an issue previously and for the others.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #279
This also standardizes handling for code suggestions. Instead of manually inserting
try: <code, you would just pass in the suggested code and delineate the suggestion's correctness withApplicabilityMachineApplicablesuggestions can be applied usingselene --fix,MaybeIncorrectcan be applied with vscode codeaction, andHasPlaceholdersonly shows up in output.selene --fixapplies suggestions iteratively, rerunning lints until there's no more suggestions. This handles the edge cases where applying a suggestion triggers another warning. It also handles overlapping suggestions where if multiple ranges overlap, it chooses the innermost one and defers the rest for the next iteration.