Skip to content

chore: remove react-dom bundle in output#494

Merged
ObservedObserver merged 2 commits intomainfrom
chore-remove-react-dom
Dec 29, 2025
Merged

chore: remove react-dom bundle in output#494
ObservedObserver merged 2 commits intomainfrom
chore-remove-react-dom

Conversation

@islxyqwe
Copy link
Member

This PR removes "react-dom/client" in the output bundle which included in v0.5.0.
also removes "react-dom/server".
reduced the result package size from 7,026.30 kB -> 5,276.59 kB (graphic-walker.es.js)

@vercel
Copy link

vercel bot commented Dec 17, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
graphic-walker Ready Ready Preview, Comment Dec 19, 2025 7:18am

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR prevents react-dom sub-modules from being bundled into the library output, reducing the bundle size from 7,026.30 kB to 5,276.59 kB (graphic-walker.es.js).

  • Adds "react-dom/client" and "react-dom/server" to the external modules list
  • Adds corresponding global variable mappings (ReactDOMClient and ReactDOMServer) for UMD builds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ObservedObserver
Copy link
Member

@codex review

@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. Bravo.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@ObservedObserver ObservedObserver merged commit 87910c2 into main Dec 29, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants