chore: remove react-dom bundle in output#494
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Pull request overview
This PR prevents react-dom sub-modules from being bundled into the library output, reducing the bundle size from 7,026.30 kB to 5,276.59 kB (graphic-walker.es.js).
- Adds "react-dom/client" and "react-dom/server" to the external modules list
- Adds corresponding global variable mappings (ReactDOMClient and ReactDOMServer) for UMD builds
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@codex review |
|
Codex Review: Didn't find any major issues. Bravo. ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This PR removes "react-dom/client" in the output bundle which included in v0.5.0.
also removes "react-dom/server".
reduced the result package size from 7,026.30 kB -> 5,276.59 kB (graphic-walker.es.js)