Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As someone that transcriber songs, it is frustrating when someone asks "Well, what songs did you make then" and not just being able to search for it. This will (just like in USDX) lead to some extra search results for a couple of generic queries (eg "rainbow" "derpy" (which also match "rainbowderpy")) but usually those people are just browsing songs anyway, so a few extra results won't really matter.
I've seen some people use "eque" as a shorthand for "equestria girls" which will also start matching "barbeque" with this change, but if you want EQG searching for "equestria" isn't the way to do it anyway lol; "girls" is much better.
NB: the first commit 355cc05 just makes it buildable again (at least on my machine) because of postgres updates and python:3 matching something that won't compile. The second commit d015da1 is the one with the actual changes. Feel free to cherry pick things.