"fix permutation of coords and feats in eagle" #147
+56
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EAGLE encoder requires that ctp and vir2 tile features are index-aligned, i.e., row i in both H5 files corresponds to the same tile location (same coordinate). Both extractors produce the same set of coordinates, however they are stored in a different order. I believe this is because of how STAMP extract features...This makes the coordinate equality check fail. The suggested patch introduces an alignment step that reorders vir2 coords & feats to match the ctp coordinate order, restoring index-level correspondence (so that the correct topk-tiles can be chosen)