Skip to content

Conversation

@stijnh
Copy link
Member

@stijnh stijnh commented Oct 13, 2025

Currently, BO throws an exception once it has fully explored the search space. This means it cannot be used for small(er) search spaces, as there is no way to catch this exception and still get the results from Kernel Tuner.

This PR replaces these exception by just breaking from the loop.

@fjwillemsen is this change ok? Could it have any adverse effects?

Copy link
Collaborator

@fjwillemsen fjwillemsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this looks good to me.

@fjwillemsen
Copy link
Collaborator

Good change, this should be handled by the interface, not individual search strategies, so this is definitely more appropriate. Although if the search space is so small as to be fully observed BO should probably not have been used in the first place.

@fjwillemsen fjwillemsen reopened this Oct 14, 2025
@sonarqubecloud
Copy link

@stijnh
Copy link
Member Author

stijnh commented Oct 14, 2025

Although if the search space is so small as to be fully observed BO should probably not have been used in the first place.

I fully agree! However, when setting time limit, you can't know in advance if that's sufficient to explore the full search space.

I will merge this PR now.

@stijnh stijnh merged commit f9b223b into master Oct 14, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants