Skip to content

Comments

Destroy Pipeline and all ShaderModule#538

Merged
rpavlik merged 1 commit intoKhronosGroup:mainfrom
remmel:main
Aug 15, 2025
Merged

Destroy Pipeline and all ShaderModule#538
rpavlik merged 1 commit intoKhronosGroup:mainfrom
remmel:main

Conversation

@remmel
Copy link
Contributor

@remmel remmel commented Mar 6, 2025

  • vkDestroyShaderModule : bug in the loop. Was always destory the 0th item
  • vkDestroyPipeline : Pipeline::Release never call. Use destructor, like in the other structs

In order to avoid thoses warnings

VK_OBJECT_TYPE_SHADER_MODULE; | MessageID = 0x4872eaa0 | vkDestroyDevice(): OBJ ERROR : For VkDevice 0x21a28d16d50[], Vk
ShaderModule 0xcfef35000000000a[] has not been destroyed.

validation layer: Validation Error: [ VUID-vkDestroyDevice-device-05137 ] Object 0: handle = 0xd10d270000000018, type =
VK_OBJECT_TYPE_PIPELINE; | MessageID = 0x4872eaa0 | vkDestroyDevice(): OBJ ERROR : For VkDevice 0x232cccfd950[], VkPipel
ine 0xd10d270000000018[] has not been destroyed.

@CLAassistant
Copy link

CLAassistant commented Mar 6, 2025

CLA assistant check
All committers have signed the CLA.

@rpavlik-bot
Copy link
Collaborator

An issue (number 2506) has been filed to correspond to this pull request in the internal Khronos GitLab (Khronos members only: KHR:openxr/openxr#2506 ), to facilitate working group processes.

This GitHub pull request will continue to be the main site of discussion.

@rpavlik-bot rpavlik-bot added the synced to gitlab Synchronized to OpenXR internal GitLab label Apr 9, 2025
Copy link
Contributor

@rpavlik rpavlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one minor tweak.

If you could also add a changelog fragment in changes/sdk/pr.538.gh.OpenXR-SDK-Source.md per the readme in there, that would be appreciated. If not I can try my hand at it.

@rpavlik rpavlik added the bug Something isn't working label Jul 24, 2025
add markdown and put back Pipeline::Release()

as asked by rpavlik
@rpavlik rpavlik enabled auto-merge (rebase) August 15, 2025 22:21
@rpavlik rpavlik merged commit 3d861ae into KhronosGroup:main Aug 15, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working synced to gitlab Synchronized to OpenXR internal GitLab

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants