Skip to content

spirv-opt: Adding rule for redundant OpLogicalEqual/OpLogicalNotEqual #6454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
alister-chowdhury wants to merge 1 commit into
base: main
Choose a base branch
from
Open

spirv-opt: Adding rule for redundant OpLogicalEqual/OpLogicalNotEqual #6454

alister-chowdhury wants to merge 1 commit into from
+158 −0

Conversation

@alister-chowdhury
Copy link
Contributor

@alister-chowdhury alister-chowdhury commented Dec 7, 2025

RedundantLogicalEqual

(a == true)  =  a
(a == false) = !a
(a != true)  = !a
(a != false) =  a

@s-perron s-perron requested review from luciechoi and s-perron and removed request for s-perron December 10, 2025 16:18
@s-perron s-perron enabled auto-merge (squash) January 5, 2026 14:20
@alister-chowdhury
spirv-opt: Adding rule for redundant OpLogicalEqual/OpLogicalNotEqual
1c0a54e 
*RedundantLogicalEqual*
```
(a == true)  =  a
(a == false) = !a
(a != true)  = !a
(a != false) =  a
```
@alister-chowdhury
Copy link
Contributor Author

alister-chowdhury commented Jan 15, 2026

I am not sure why CI-macos-clang-debug is failing (I can't access fusion2).
But I'm going to just rebase and hope for the best.

auto-merge was automatically disabled January 15, 2026 05:10

Head branch was pushed to by a user without write access

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@luciechoi luciechoi luciechoi approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@alister-chowdhury @luciechoi @kokoro-team @s-perron