Skip to content

Calculated the bounds of the imported SkinnedMeshRenderer. #878

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Calculated the bounds of the imported SkinnedMeshRenderer. #878

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ddb5cb6
Calculated the bounds of the imported SkinnedMeshRenderer.
XtroTheArctic Jun 29, 2025
106ac9d
Merge remote-tracking branch 'official/dev' into dev
XtroTheArctic Jul 13, 2025
dc108be
Merge branch 'dev' into feature/876-CalculateBounds
XtroTheArctic Jul 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 16 additions & 3 deletions Runtime/Scripts/GLTFSceneImporter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1008,7 +1008,18 @@ protected virtual async Task ConstructNode(Node node, int nodeIndex, Cancellatio
nodeObj.transform.localRotation = rotation;
nodeObj.transform.localScale = scale;


Bounds TransformBounds(Matrix4x4 matrix, Bounds bounds)
{
var extents = bounds.extents;
var ax = matrix.MultiplyVector(new Vector3(extents.x, 0, 0));
var ay = matrix.MultiplyVector(new Vector3(0, extents.y, 0));
var az = matrix.MultiplyVector(new Vector3(0, 0, extents.z));
var x = Mathf.Abs(ax.x) + Mathf.Abs(ay.x) + Mathf.Abs(az.x);
var y = Mathf.Abs(ax.y) + Mathf.Abs(ay.y) + Mathf.Abs(az.y);
var z = Mathf.Abs(ax.z) + Mathf.Abs(ay.z) + Mathf.Abs(az.z);

return new Bounds(matrix.MultiplyPoint3x4(bounds.center), new Vector3(x, y, z) * 2f);
}

async Task CreateNodeComponentsAndChilds(bool ignoreMesh = false, bool onlyMesh = false)
{
Expand Down Expand Up @@ -1048,8 +1059,10 @@ async Task CreateNodeComponentsAndChilds(bool ignoreMesh = false, bool onlyMesh
if (node.Skin != null)
await SetupBones(node.Skin.Value, renderer, cancellationToken);

// morph target weights
if (weights != null)
renderer.localBounds = renderer.rootBone == null ? unityMesh.bounds : TransformBounds(renderer.rootBone.worldToLocalMatrix * renderer.transform.localToWorldMatrix, unityMesh.bounds);

// morph target weights
if (weights != null)
{
for (int i = 0; i < weights.Count; ++i)
{
Expand Down