CCurl available only for Linux or macOS

[makleso6]

CCurl available only for Linux or macOS. I Use Kitura on iOS platform, so I move CCurl in other scope

Description

Create flag KITURA_IOS
for Linux or macOS ClientRequest available(no need use CCurl on iOS )
for Linux or macOS HTTP methods available(no need use CCurl on iOS )

Motivation and Context

Use Kitura WebServer on iOS platform without magic

How Has This Been Tested?

I think tests no needed

Checklist:

• I have submitted a CLA form
• If applicable, I have updated the documentation accordingly.
• If applicable, I have added tests to cover my changes.

[djones6]

@makleso6 Apologies for the delay in reviewing your PR. Other than my suggestion on the #if syntax this change looks fine to me.

We'll want to document the KITURA_IOS flag somewhere - could you add a mention of it to the README, perhaps a new heading called 'Optional compilation flags'?

[djones6]

I think I'd prefer us to test on the KITURA_IOS flag as it's then consistent with the conditions for the CCurl dependency in Package.swift, eg:

#if !KITURA_IOS

[djones6]

Same comment as above

[makleso6]

@djones6 I'll try it

[makleso6]

@djones6 D you think that the removal ClientRequest in !KITURA_IOS good practice?
Or I need to write ClientRequest iOS class over URLSession.
because tests on iOS does not work :(

[djones6]

The Kitura and Kitura-net tests are heavily dependent on ClientRequest so yes, if you wanted to be able to run the tests on iOS using Kitura-net then we'd need a replacement.

You could potentially look at using Kitura-NIO instead: Kitura-NIO uses Swift-NIO and doesn't depend on Curl. To use it, set KITURA_NIO when you compile.

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ makleso6
❌ djones6
_{You have signed the CLA already but the status is still pending? Let us recheck it.}