Skip to content

feat(ConnectivityFilter): add vtkConnectivityFilter#3436

Merged
finetjul merged 3 commits intoKitware:masterfrom
qianlishun:feature/connectivity-filter
Mar 23, 2026
Merged

feat(ConnectivityFilter): add vtkConnectivityFilter#3436
finetjul merged 3 commits intoKitware:masterfrom
qianlishun:feature/connectivity-filter

Conversation

@qianlishun
Copy link
Copy Markdown
Contributor

Context

add vtkConnectivityFilter
Use BFS to find connected regions and extract regions

Results

github-1 guthub-2

Changes

only add .js, no .ts

PR and Code Checklist

  • semantic-release commit messages
  • Run npm run reformat to have correctly formatted code

Testing

  • This change adds example tests
  • Tested environment:
    • vtk.js:
    • OS:
    • Browser:

Copy link
Copy Markdown
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not looked closely, but if the algorithm differs from the C++ vtkConnectivityFilter, you would need to come up with a different filter name.

Please :

  • add an index.d.ts file
  • add a screenshot for the example image gallery
  • consider using existing functions such as getCellPoints() and getPointCells().

Thanks !

@qianlishun
Copy link
Copy Markdown
Contributor Author

I have not looked closely, but if the algorithm differs from the C++ vtkConnectivityFilter, you would need to come up with a different filter name.

Please :

  • add an index.d.ts file
  • add a screenshot for the example image gallery
  • consider using existing functions such as getCellPoints() and getPointCells().

Thanks !

The filter has been renamed as BFSConnectivity Filter;
Added index.d.ts and screenshot
The polydata method has been used to replace the original.

Please review.
Thanks !

Copy link
Copy Markdown
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@finetjul finetjul added this pull request to the merge queue Mar 23, 2026
Merged via the queue into Kitware:master with commit 9d00695 Mar 23, 2026
2 checks passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 35.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label Mar 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

released Automated label

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants