Skip to content

Reload on SIGHUP signal when BaseReload class is used (one worker) #2596

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Reload on SIGHUP signal when BaseReload class is used (one worker) #2596

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3417411
Reload on SIGHUP signal when BaseReload class is used (no. of workers…
defue Mar 11, 2025
617c894
fix typos
defue Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 9 additions & 3 deletions uvicorn/supervisors/basereload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@
HANDLED_SIGNALS = (
signal.SIGINT, # Unix signal 2. Sent by Ctrl+C.
signal.SIGTERM, # Unix signal 15. Sent by `kill <pid>`.
signal.SIGHUP, # Unix signal 1. Used for reloading.
)

logger = logging.getLogger("uvicorn.error")
Expand All @@ -43,10 +44,15 @@ def signal_handler(self, sig: int, frame: FrameType | None) -> None: # pragma:
"""
A signal handler that is registered with the parent process.
"""
if sys.platform == "win32" and self.is_restarting:
self.is_restarting = False
if sig == signal.SIGHUP:
logger.info("Received SIGHUP. Reloading...")
self.restart()
else:
self.should_exit.set()
# shutdown
if sys.platform == "win32" and self.is_restarting:
self.is_restarting = False
else:
self.should_exit.set()

def run(self) -> None:
self.startup()
Expand Down
Loading