This repository was archived by the owner on Sep 23, 2022. It is now read-only.
Open
Conversation
Use Twig namespaces
Test PHP 7.4
Fix PHP 5.5 test
Fixed Mailer bc break
Make 2.x tests green again
Revert UserManagerInterface::updateUser() BC break
Safe option on XML mapping was removed on doctrine/mongodb-odm 2.0
Changed suggested example encoder from bcrypt to auto
Deprecate Groups
Add native return types
Remove the implementation of the old UserProviderInterface method
Remove unnecessary compatibility checks in tests
Convert XML config files to PHP or Yaml
The PasswordUpdater implementation resets the plain password to `null` after hashing the password, marking the fact that a next code (done in a Doctrine listener for instance) would not need to hash anything anymore. Instead of relying on `UserInterface::eraseCredentials` which is deprecated in Symfony 7.3+ and not guaranteed to implement this behavior if the entity overrides the method, the `null` is now set explicitly.
This is technically a BC break for projects extending this class and overriding the method. However, there is no use case for extending this class instead of implementing the Symfony interface directly.
Fix Symfony deprecations
Fix coding standards
Symfony has deprecated the XML format for route definitions. The bundle now ships PHP routing files in addition to the XML ones (with tests ensuring they are in sync) and the documentation uses the PHP files. The XML files will be removed in the next major version of the bundle as removing them is a BC break.
Provide PHP routing files in parallel of the XML ones
Install phpunit as a dev dependency directly
- add jobs on PHP 8.4 and 8.5 - add a job for the 7.4 LTS - update actions
Update the CI setup
This also bumps the min PHP version to 8.2 as Symfony 7 does not support PHP 8.1.
Bump the min Symfony version to 7.3
This avoids the deprecation warning of Symfony about the deprecation of the method. Our User class already excludes the plain password from the serialized data even when this method is not called.
Mark `User::eraseCredentials` as deprecated
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
// vendor/friendsofsymfony/user-bundle/Model/User.php
...
use Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface;
...
//add implements PasswordAuthenticatedUserInterface
abstract class User implements UserInterface,PasswordAuthenticatedUserInterface, EquatableInterface, \Serializable
{
.....
//add :?string to be compatible with PasswordAuthenticatedUserInterface
public function getPassword():?string
{
}
...
}