Skip to content

feat: SONOFF TRVZB add smart thermostat features (v1.4.4) #11466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CubeZ2mDeveloper wants to merge 5 commits into
base: master
Choose a base branch
from
+19 −0
Open

feat: SONOFF TRVZB add smart thermostat features (v1.4.4) #11466

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
66820e8
feat(improve): SONOFF TRVZB add smart temperature control
CubeZ2mDeveloper Feb 4, 2026
61de1d8
Apply suggestion from @grossermax
Koenkk Feb 5, 2026
054c997
Update src/devices/sonoff.ts
CubeZ2mDeveloper Feb 6, 2026
a8e0a8f
fix: SONOFF TRVZB: the incorrect naming of the smartTempControl extend
CubeZ2mDeveloper Feb 6, 2026
f8b6b69
feat(improve): SONOFF TRVZB: refactor smartTempControl to use m.enumL…
CubeZ2mDeveloper Feb 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions src/devices/sonoff.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ interface SonoffTrvzb {
temporaryMode: number;
temporaryModeTime: number;
temporaryModeTemp: number;
smartTempControl: number;
};
commands: never;
commandResponses: never;
Expand Down Expand Up @@ -2388,6 +2389,7 @@ export const definitions: DefinitionWithExtend[] = [
write: true,
max: 0xff,
},
smartTempControl: {ID: 0x6017, type: Zcl.DataType.BITMAP8, write: true},
},
commands: {},
commandsResponse: {},
Expand Down Expand Up @@ -2579,6 +2581,23 @@ export const definitions: DefinitionWithExtend[] = [
}),
sonoffExtend.weeklySchedule(),
m.customTimeResponse("1970_UTC"),
m.enumLookup<"customSonoffTrvzb", SonoffTrvzb>({
name: "smart_temperature_control",
// manual sends 0x00 (same as off), 0x01 is report-only
lookup: {off: 0x00, manual: 0x00, smart: 0x02},
Copy link
Contributor

@ActuallyRuben ActuallyRuben Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lookup: {off: 0x00, manual: 0x00, smart: 0x02},
lookup: {off: 0x00, on: 0x02},

cluster: "customSonoffTrvzb",
attribute: "smartTempControl",
description:
"Manual mode: off or manual (same effect), Smart mode: automatic temperature control. " +
'After enabling the smart mode, "Valve Opening Percentage" and "Temperature Accuracy" will be automatically disabled.',
Comment on lines +2591 to +2592
Copy link
Contributor

@ActuallyRuben ActuallyRuben Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"Manual mode: off or manual (same effect), Smart mode: automatic temperature control. " +
'After enabling the smart mode, "Valve Opening Percentage" and "Temperature Accuracy" will be automatically disabled.',
'Off: fully opens or closes the radiator valve based on a threshold temperature, ' +
'On: adjust valve opening based on a PID algorithm. ' +
'After enabling the smart mode, "Valve Opening Percentage" and "Temperature Accuracy" will be automatically disabled.',

access: "ALL",
fzConvert: (model, msg, publish, options, meta) => {
if ("smartTempControl" in msg.data) {
const valueToMode: Record<number, string> = {0: "off", 1: "manual", 2: "smart"};
Copy link
Contributor

@ActuallyRuben ActuallyRuben Feb 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const valueToMode: Record<number, string> = {0: "off", 1: "manual", 2: "smart"};
const valueToMode: Record<number, string> = {0: "off", 1: "off", 2: "on"};

return {smart_temperature_control: valueToMode[msg.data.smartTempControl] ?? "off"};
}
},
}),
],
ota: true,
configure: async (device, coordinatorEndpoint) => {
Expand Down