Fix typo: thread.deamon -> thread.daemon in core/runtime.py - #326
Merged
Conversation
Thread objects allow arbitrary attribute assignment, so the typo'd 'deamon' attribute was silently set instead of the real 'daemon' attribute, leaving the worker thread non-daemon. This can prevent the host process from exiting cleanly. Fixes KoljaB#325
Owner
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RealtimeSTT/core/runtime.pyline 27:thread.deamon = Trueshould bethread.daemon = True.Threadobjects allow arbitrary attribute assignment, the typo silently created a bogusdeamonattribute instead of setting the realdaemonflag, leaving the worker thread non-daemon. This can prevent the host process from exiting cleanly.Verification
deamon— only the one occurrence found and fixed; zero remaining after the change..deamon(i.e. nothing relies on the buggy behavior).Fixes #325
Note: this fix was prepared with AI assistance (no CONTRIBUTING.md disclosure requirement found in the repo).