Conversation
koperagen
added
the
documentation
koperagen
force-pushed
the
replace-all-docs
branch
from
47a401d to
2df4ca2
Compare
koperagen
force-pushed
the
replace-all-docs
branch
from
2df4ca2 to
815f9ec
Compare
Contributor
|
Generated sources will be updated after merging this PR. |
Collaborator
Author
|
|
Jolanrensen
reviewed
Jun 20, 2024
| <!---FUN replaceAll--> | ||
|
|
||
| ```kotlin | ||
| functions.replaceAll( |
Collaborator
There was a problem hiding this comment.
the replaceAll call looks a bit out of place in between all these update functions, it should be in replace, shouldn't it? https://kotlin.github.io/dataframe/replace.html
Fillnulls https://kotlin.github.io/dataframe/fill.html is also an update "flavour", just like replaceAll, but it also has a separate page
Collaborator
There was a problem hiding this comment.
you could provide a link from here to replaceAll though, but probably at the bottom
Collaborator
|
@koperagen what's is the future of this PR? Seems like outdated and hard to maintain? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I decided to experiment with a new dataset