Add generic aliases for collection types #94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KotlinIsland
force-pushed
the
aliasses
branch
from
f144ead to
41ba5d0
Compare
KotlinIsland
force-pushed
the
aliasses
branch
from
41ba5d0 to
7fea972
Compare
DetachHead
reviewed
Jan 5, 2024
Comment on lines
+564
to
+570
| dict_keyiterator = _collections_abc.dict_keyiterator # type: ignore[attr-defined] | ||
| dict_valueiterator = _collections_abc.dict_valueiterator # type: ignore[attr-defined] | ||
| dict_itemiterator = _collections_abc.dict_itemiterator # type: ignore[attr-defined] | ||
| list_iterator = _collections_abc.list_iterator # type: ignore[attr-defined] | ||
| list_reverseiterator = _collections_abc.list_reverseiterator # type: ignore[attr-defined] | ||
| set_iterator = _collections_abc.set_iterator # type: ignore[attr-defined] | ||
| tuple_iterator = _collections_abc.tuple_iterator # type: ignore[attr-defined] |
There was a problem hiding this comment.
these shouldnt be here because they dont exist. if theres a reason to assume theyll exist in the future there should be a comment saying so
KotlinIsland
force-pushed
the
master
branch
2 times, most recently
from
3b2e955 to
e7761a1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_aliass fordict_keysetc #29