few cosmetic changes and with C++17 no need to explictly define copy … #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caiiiycuk
reviewed
Aug 10, 2022
| OggStream::OggStream(const std::string &fname) { | ||
| _file = fopen(fname.c_str(), "rb"); | ||
| OggStream::OggStream(const std::string_view fname) { | ||
| _file = fopen(fname.data(), "rb"); |
Contributor
There was a problem hiding this comment.
why data is more preferable then c_str()?
Contributor
Author
There was a problem hiding this comment.
simply because there is no such things with string_view :-) it s chunk of bytes that s how it gains perf over a traditional std string, no need allocation.
Contributor
|
Firstly I should migrate it to flatpack for steam, before we can use C++17. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…constructors.