-
Notifications
You must be signed in to change notification settings - Fork 277
[CI] Testing the C++20 compilation #13549
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@roigcarlo looks like C++20 will not be out of the box |
|
There is a pr open to actualize the boost versión, did u use that? |
|
No, I was just changing cmake flag to see what happened
El sáb., 21 jun. 2025 14:57, Riccardo Rossi ***@***.***>
escribió:
… *RiccardoRossi* left a comment (KratosMultiphysics/Kratos#13549)
<#13549 (comment)>
There is a pr open to actualize the boost versión, did u use that?
—
Reply to this email directly, view it on GitHub
<#13549 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYQZABIFPAXZBFQG46NQ5D3EVJFJAVCNFSM6AAAAAB7ZXLZC2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDSOJTGU3DONBRGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Which PR? |
|
Ah, Okay, thats an issue, not a PR |
still i think it should solve your problem here |
Yes, looks like |
Try windows build with boost 1.87
|
I've updated the win builds to use boost 1.87 uf it works we can update the images for linux if we decide to move on |
.github/workflows/ci.yml
Outdated
|
|
||
| - name: Download boost | ||
| run: | | ||
| $url = "https://archives.boost.io/release/1.74.0/source/boost_1_74_0.tar.gz" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like is not enough
|
Looks like this needs further refactoring... |
|
Ok next build should use the new containers with boost 1.87, let see if it compiles now |
|
@roigcarlo the compilation errors here are exactly the sme I found in my machine, I thougth compilationnwas working. |
|
Should have, Ill take a closer look tomorrow to see what's happening |
|
What is the status of this? |
…into ci/test-c++20
|
@loumalouomega why did you merge the master again, i just did it 1h ago :S |
Ups, sorry, i didn't noticed. BTW, any idea how to solve the Rocky issue? |
|
Tada!! 🎉 |
Hurray |
|
Okay, I hope nothing is broken |
📝 Description
Testing the C++20 compilation.
🆕 Changelog