-
Notifications
You must be signed in to change notification settings - Fork 277
[CI] Adding new boost version to docker files #13580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| RUN apt-get -y install --no-install-recommends gnupg2 software-properties-common wget | ||
|
|
||
| # Adding intel ppa and installing packages | ||
| RUN wget https://apt.repos.intel.com/intel-gpg-keys/GPG-PUB-KEY-INTEL-SW-PRODUCTS.PUB -P/tmp && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do you use multipe RUN sections? This can considerably increase the size of the image!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because we share the same layers for multiple containers internally, it is true that individually they weight more, but globally the reduction is considerable.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you elaborate what you mean by internally? Multistage builds?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No multistage, I have several flavours of images, for example the most typical usage is to change the MMG/Python/boost versions (I have builds with different permutations of those lib versions). By splitting those into layers I save a lot of space because the base is common for all of them.
📝 Description
Continuation of #13559. This should add the new version to the CI images that still don't have it.
Mind that boost will now be installed separate from the manager, so all images will still use the old one. On a following PR or when the images are built I will update the configures so they target the correct lib.
I've done it this way so in the future we can just have a transition state with a container with multiple versions of the lib without breaking the production CI. (not like it is right now, as we depend on the version of apt)
Also took the opportunity to remove the 18.04 images.