Skip to content

Conversation

@roigcarlo
Copy link
Member

📝 Description
Continuation of #13559. This should add the new version to the CI images that still don't have it.

Mind that boost will now be installed separate from the manager, so all images will still use the old one. On a following PR or when the images are built I will update the configures so they target the correct lib.

I've done it this way so in the future we can just have a transition state with a container with multiple versions of the lib without breaking the production CI. (not like it is right now, as we depend on the version of apt)

Also took the opportunity to remove the 18.04 images.

@roigcarlo roigcarlo requested a review from a team as a code owner July 2, 2025 08:02
@roigcarlo roigcarlo merged commit ad1d19c into master Jul 5, 2025
13 of 19 checks passed
@roigcarlo roigcarlo deleted the ci/bump-boost-ubuntu-docker branch July 5, 2025 15:21
RUN apt-get -y install --no-install-recommends gnupg2 software-properties-common wget

# Adding intel ppa and installing packages
RUN wget https://apt.repos.intel.com/intel-gpg-keys/GPG-PUB-KEY-INTEL-SW-PRODUCTS.PUB -P/tmp && \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you use multipe RUN sections? This can considerably increase the size of the image!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because we share the same layers for multiple containers internally, it is true that individually they weight more, but globally the reduction is considerable.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you elaborate what you mean by internally? Multistage builds?

Copy link
Member Author

@roigcarlo roigcarlo Jul 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No multistage, I have several flavours of images, for example the most typical usage is to change the MMG/Python/boost versions (I have builds with different permutations of those lib versions). By splitting those into layers I save a lot of space because the base is common for all of them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants