Skip to content

[CORE] Fix IsInside of Truss_3D_2#14304

Open
Igarizza wants to merge 4 commits intomasterfrom
core/fix_line_3d_2_IsInside
Open

[CORE] Fix IsInside of Truss_3D_2#14304
Igarizza wants to merge 4 commits intomasterfrom
core/fix_line_3d_2_IsInside

Conversation

@Igarizza
Copy link
Copy Markdown
Member

@Igarizza Igarizza commented Mar 17, 2026

📝 Description
Fix the Point Projection onto the truss element in the 3D case by adding the distance check.

Corner Case:

Point (-16, 2.5, 0)

r_element : Element #21 :
Working space dimension : 3
Local space dimension : 1

Point 1	 :  (-20, 0, 0)
Dofs :
    Free TEMPERATURE degree of freedom
    Free DISPLACEMENT_X degree of freedom
    Free DISPLACEMENT_Y degree of freedom
    Free DISPLACEMENT_Z degree of freedom

Point 2	 :  (-20, 5, 0)
Dofs :
    Free TEMPERATURE degree of freedom
    Free DISPLACEMENT_X degree of freedom
    Free DISPLACEMENT_Y degree of freedom
    Free DISPLACEMENT_Z degree of freedom

Center	 :  (-20, 2.5, 0)

rResult[0] : 0.886796

Expected to be False, Returns True.

@Igarizza Igarizza requested a review from sunethwarna March 17, 2026 17:40
@Igarizza Igarizza requested a review from a team as a code owner March 17, 2026 17:40
@Igarizza Igarizza self-assigned this Mar 18, 2026
@Igarizza Igarizza changed the title [CORE] Fix Point Projection onto Truss_3D_2 [CORE] Fix IsInside of Truss_3D_2 Mar 18, 2026
Copy link
Copy Markdown
Member

@sunethwarna sunethwarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Igarizza :)

@philbucher
Copy link
Copy Markdown
Member

FYI not sure this is the way to go, check #7401

=> IMO the projection should happen separately (see geom-projection-utils)

@Igarizza
Copy link
Copy Markdown
Member Author

FYI not sure this is the way to go, check #7401

=> IMO the projection should happen separately (see geom-projection-utils)

Well, I have revered the projection and only adding the distance check. For sure it makes the function more expansive.

@matekelemen
Copy link
Copy Markdown
Contributor

FYI not sure this is the way to go, check #7401

=> IMO the projection should happen separately (see geom-projection-utils)

Wow this topic is old. How on earth did this never get merged?!

@philbucher
Copy link
Copy Markdown
Member

Wow this topic is old. How on earth did this never get merged?!

tests were failing, and I guess not enough interest to fix it 🤷

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants