Open
Conversation
added 2 commits
March 17, 2026 19:09
Member
|
FYI not sure this is the way to go, check #7401 => IMO the projection should happen separately (see geom-projection-utils) |
Member
Author
Well, I have revered the projection and only adding the distance check. For sure it makes the function more expansive. |
Contributor
Wow this topic is old. How on earth did this never get merged?! |
Member
tests were failing, and I guess not enough interest to fix it 🤷 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Description
Fix the Point Projection onto the truss element in the 3D case by adding the distance check.
Corner Case:
Point (-16, 2.5, 0)
r_element : Element #21 :
Working space dimension : 3
Local space dimension : 1
rResult[0] : 0.886796
Expected to be False, Returns True.