[NodeBundle] Show url slug in wysiwyg

[waaghals]

Q	A
Bug fix?	yes
New feature?	yes
BC breaks?	no
Deprecations?	no
Fixed tickets	#1910

This PR adds back the slug for the selected page in wysiwyg editors. This allows end users to recognize what page they have picked. The id is still used internally, so even when the slug changes, this correct link is generated in the frontend. (Although the slug in the wysiwyg stays the same)

[ProfessorKuma]

Hi @waaghals, your PR needs some changes

• your PR title should look like [SomeBundle] Fixed some code

[acrobat]

@waaghals can you rebase this pr so the conflicts are solved and can you provide some screenshots to see how this will look in the cms? Thanks!

[ProfessorKuma]

Hi @, your PR needs some changes

• This PR seems to need a milestone of a minor release.

[dannyvw]

@waaghals ping ;)

[waaghals]

Old

New

Note: Different installations, so id is different between screenshots.

With the new link format, the editor can see to which page the link is referring to.

[ProfessorKuma]

Hi @, your PR passed all our requirements.

Thank you for contributing!

[waaghals]

@acrobat rebased the PR and I've added a screenshot with the old and the new link format.

[acrobat]

@waaghals Thanks for the update! Can you check the failing travis build and styleci?
I'm thinking if it would be possible to make the wysiwyg always display the correct slug in the textarea? With some callback function on load of the editor or ...?

Do you have an idea to "fix" this in ckeditor @dbeerten?

[dannyvw]

@acrobat Done

[acrobat]

This still needs some work on the editor side as it would be more userfriendly to always show the correct slug for a link. I'm removing the milestone so we finish this somewhere in 6.x