[AllBundles] Configure asset packages and add package to asset call#2776
[AllBundles] Configure asset packages and add package to asset call#2776dannyvw wants to merge 3 commits intoKunstmaan:masterfrom
Conversation
ProfessorKuma
left a comment
ProfessorKuma
left a comment
There was a problem hiding this comment.
Hi @, your PR needs some changes
- This PR seems to need a milestone of a minor release.
ProfessorKuma
left a comment
ProfessorKuma
left a comment
There was a problem hiding this comment.
Hi @, your PR passed all our requirements.
Thank you for contributing!
| ], | ||
| ], | ||
| ]; | ||
| $container->prependExtensionConfig('framework', $frameworkExtensionConfig); |
There was a problem hiding this comment.
Not sure if this is the right bundle, but there is no core bundle available. Maybe move to the admin bundle?
There was a problem hiding this comment.
Yes indeed this needs to moved to the admin bundle as most of the other bundles (if not all) have the admin bundle as a dependency. Also the minimum version needs to be bumped in those bundle composer files
There was a problem hiding this comment.
Configuration moved. Which composer files needs a change?
src/Kunstmaan/MediaBundle/DependencyInjection/KunstmaanMediaExtension.php
Outdated
Show resolved
Hide resolved
dannyvw
force-pushed
the
asset-package
branch
3 times, most recently
from
9ee3ece to
308bb43
Compare
dannyvw
force-pushed
the
asset-package
branch
2 times, most recently
from
83a4a7e to
5a59bbb
Compare
dannyvw
force-pushed
the
asset-package
branch
2 times, most recently
from
2c94ac0 to
19fc3c4
Compare
|
@acrobat Do you have an update for this? |
|
@dannyvw I've assigned this PR to myself, so I can test it in a real project. Can you rebase against the current master as it makes it easier to test it and have the new github actions setup here. |
|
@acrobat Done |
dannyvw
force-pushed
the
asset-package
branch
2 times, most recently
from
7dbe06d to
21c8236
Compare
dannyvw
force-pushed
the
asset-package
branch
from
21c8236 to
565c0b4
Compare
3 participants
Configure asset package in Symfony and use this for all asset calls. With this change it is possible to configure a different base_url for different assets. The generate urls are default the same as before.
Also a few changes from #2769 are added in this PR.