[MediaBundle] Change media path usage#2784
Open
dannyvw wants to merge 1 commit intoKunstmaan:masterfrom
Open
Conversation
ProfessorKuma
suggested changes
Oct 9, 2020
ProfessorKuma
left a comment
ProfessorKuma
left a comment
There was a problem hiding this comment.
Hi @, your PR needs some changes
- This PR seems to need a milestone of a minor release.
ProfessorKuma
approved these changes
Oct 9, 2020
ProfessorKuma
left a comment
ProfessorKuma
left a comment
There was a problem hiding this comment.
Hi @, your PR passed all our requirements.
Thank you for contributing!
dannyvw
force-pushed
the
media-upload-path
branch
2 times, most recently
from
a776c3c to
0180f19
Compare
Contributor
Author
|
@acrobat Do you have an update for this? |
acrobat
reviewed
Apr 25, 2021
src/Kunstmaan/MediaBundle/DependencyInjection/KunstmaanMediaExtension.php
Outdated
Show resolved
Hide resolved
src/Kunstmaan/MediaBundle/DependencyInjection/KunstmaanMediaExtension.php
Outdated
Show resolved
Hide resolved
acrobat
reviewed
Oct 12, 2021
| class: Gaufrette\Adapter\Local | ||
| arguments: | ||
| - '%kunstmaan_media.full_media_path%' | ||
| - '%kunstmaan_media.web_root%' |
Member
There was a problem hiding this comment.
Isn't this change "wrong" as it currently injects path/to/web/root/uploads/media/ and now would inject path/to/web/root?
Contributor
Author
There was a problem hiding this comment.
uploads/media is handled in the FileHandler. We already using this configuration without any problems.
dannyvw
force-pushed
the
media-upload-path
branch
from
8299aa1 to
ad958cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easier to use one remote storage configuration for the complete application