[NodeBundle] | (fix) nullable nodetranslation in slugtype#3483
Open
mart-insiders wants to merge 1 commit intoKunstmaan:7.xfrom
Open
[NodeBundle] | (fix) nullable nodetranslation in slugtype#3483mart-insiders wants to merge 1 commit intoKunstmaan:7.xfrom
mart-insiders wants to merge 1 commit intoKunstmaan:7.xfrom
Conversation
Member
|
@mart-insiders can you rebase against the current 7.x branch and target the PR to 7.x. Master is no longer used and is an old state of the project. Thanks! |
mart-insiders
force-pushed
the
slugtype
branch
from
2ca967e to
c37c41a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The buildView method in SlugType can throw a 500 error when a nodeTranslation is not found in parentNode->getNodeTranslation(). Adding a simple nullcheck resolves this.
This bug occurs when a multilangual site had a subpage under a parent node which is not translated. This can be resolved by creating the parent node translation but shouldn't crash the CMS