Skip to content

Sample validation DQM PIDs need to shift #1920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
tvami wants to merge 1 commit into
base: trunk
Choose a base branch
from
Open

Sample validation DQM PIDs need to shift #1920

tvami wants to merge 1 commit into from

Conversation

@tvami
Copy link
Member

@tvami tvami commented Jan 22, 2026 •
edited
Loading

I am updating ldmx-sw, here are the details.

What are the issues that this addresses?

When shooting a 622 particle it ends up in the strange barion category, and shooting other stuff ends up in A' instead of the else category

Screenshot 2026-01-22 at 11 55 27

Check List

  • I successfully compiled ldmx-sw with my developments.
  • I read, understood and follow the coding rules.
  • I ran my developments and the following shows that they are successful.
Screenshot 2026-01-22 at 20 51 04

(For the record I was shooting a tau)

@tvami tvami force-pushed the fix-sample-validation-pids branch 3 times, most recently from 342605b to ce20109 Compare January 23, 2026 04:55
@tvami tvami changed the title Sample validation DQM PIDs needs to shift Sample validation DQM PIDs need to shift Jan 23, 2026
@tvami tvami marked this pull request as draft January 23, 2026 04:58
@tvami tvami marked this pull request as ready for review January 23, 2026 04:58
@tvami tvami requested a review from tomeichlersmith January 23, 2026 04:58
@tvami tvami force-pushed the fix-sample-validation-pids branch from 6823e40 to 2f50372 Compare January 23, 2026 05:06
@tvami tvami marked this pull request as draft January 23, 2026 05:16
@tvami tvami marked this pull request as ready for review January 23, 2026 05:16
@tvami
Copy link
Member Author

tvami commented Jan 23, 2026

For the record, @y-Li1145 found this issue

@tvami tvami requested a review from y-Li1145 January 23, 2026 05:41
@tvami
Copy link
Member Author

tvami commented Jan 23, 2026

The CI plots show that we've been mislabeling a few things all along haha

Screenshot 2026-01-23 at 10 31 38

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@y-Li1145 y-Li1145 y-Li1145 approved these changes

@tomeichlersmith tomeichlersmith Awaiting requested review from tomeichlersmith

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tvami @y-Li1145