Move NiProof struct to parent module in zk factoring of a RSA modulus #160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dulus Signed-off-by: jfdreis <[email protected]>
survived
approved these changes
Sep 1, 2025
Contributor
survived
left a comment
survived
left a comment
There was a problem hiding this comment.
Perfect! Thanks for updating all the proofs!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR partially addresses one of the TODOs from #151 : Refactor NI proofs so they accept NiProof.
The
Proofstruct for the Non_interactive ZK-proof for factoring of a RSA modulus was already define under thenon_interactivemodule. I moved it to the parent module, rename it toNiProof, and update the code accordingly.Together with PRs #154, #155, #156 , #157, and #158, this completes the Refactor of NI Proofs. (see #151).