chore: Nonce::from_bytes() returns Self instead of Option<Self>#206
Closed
tvolk131 wants to merge 1 commit intoLLFourn:masterfrom
Closed
chore: Nonce::from_bytes() returns Self instead of Option<Self>#206tvolk131 wants to merge 1 commit intoLLFourn:masterfrom
tvolk131 wants to merge 1 commit intoLLFourn:masterfrom
Conversation
Collaborator
|
Hey @tvolk131, I asked Lloyd about this one and it due to the fact that not every 33 byte array will render a valid Point, see |
Owner
|
Yes it's very important that not all 33 byte arrays are valid points because not all 32 byte arrays are valid x-coordinates on secp256k1 (around half are not!). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Point::from_slice()only returnsNoneif it is passed a byte slice that isn't exactly 33 bytes long. SinceNonce::from_bytes()always passes in 33 bytes, we can guarantee to the caller that this never fails.