Merged
Conversation
a2d7788 to
2cc7300
Compare
2cc7300 to
a8833f9
Compare
nickfarrow
approved these changes
Nov 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SharedKey::from_non_zero_polySharedKey::grind_fingerprintmethodShareImagetypepoly::scalar::to_point_polyto make it less opinionatedScalarto all unsigned integer typesCompactProofinsigma_funto use two type parametersCompactProof<R, L>instead ofCompactProof<S: Sigma>to enable serde supportsecp256kfun_arithmetic_macrosto use genericNonZero<T>type instead ofNonZeroU32Point:hash_to_curve- Simple try-and-increment with uniform distribution (recommended)hash_to_curve_sswu- RFC 9380 compliant constant-time hashinghash_to_curve_rfc9381_tai- RFC 9381 VRF try-and-increment formatMessage::newfor BIP340-compliant domain separation using 33-byte padded prefixMessage::plainwhich uses non-standard 64-byte prefixMessageandSignaturetypes (always public now)Slicetype from secp256kfunSharedKey::check_fingerprintnow returnsOption<usize>instead ofbool, indicating number of bits verifiedPartyIndextoShareIndexfrom_bytes_uncompressedto validate points are on curvevrf_funcratePoint<_, _, Zero>implementsHash