Fix Nonce Reuse in RFC 9381 VRF Proof#244
Merged
LLFourn merged 1 commit intoLLFourn:masterfrom Mar 3, 2026
Merged
Conversation
Owner
|
Yes @rot256 please use the rng argument. Thanks! |
gen_rng used a fresh hasher instead of the transcript state, making the nonce depend only on the secret key. Two proofs with different inputs shared the same nonce, enabling full secret key recovery: x = (s1 - s2) / (c1 - c2).
Contributor
Author
|
There ya go! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ensures that the
Rngused in the sigma protocol depend on the whole transcript, including the input. Currently the fix still does not sample from theRng, let me know if you would like this defense in depth.