Add jupyter notebook execution as CI test#474
Open
joezuntz wants to merge 13 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a new CI job intended to execute the “Welcome to TXPipe” Jupyter notebook to ensure it continues to run successfully, while also making several small pipeline/IO fixes that support running the example workflow.
Changes:
- Add a GitHub Actions “Notebook” job that restores the cached conda env + example data and runs the welcome notebook.
- Fix/align Fourier/covariance metadata and map-handling (binning metadata parsing, mask/map Healpix reads, tracer bin counts).
- Update defaults/dependencies to support the example workflow (mask threshold default, bump
saccversion).
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
txpipe/utils/nmt_utils.py |
Allow ell-binning recovery from SACC metadata by stripping binning/ prefixes. |
txpipe/twopoint_fourier.py |
Minor noise-metadata logic cleanup and a whitespace-only change. |
txpipe/metadata.py |
Add nbin_source / nbin_lens into produced metadata. |
txpipe/maps.py |
Change default mask_threshold for density-map generation. |
txpipe/covariance.py |
Switch to Healpix reads and resample mask to match density-map resolution; adjust mask-name mapping. |
bin/environment-perlmutter.yml |
Bump sacc[all] requirement. |
bin/environment-local.yml |
Bump sacc[all] requirement. |
.github/workflows/ci.yml |
Add Notebook CI job to execute the welcome notebook. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure the welcome notebook works