Cov benchmark#43
Open
c-d-leonard wants to merge 4 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a benchmark (vs legacy code) for the covariance implementation. It includes a script for running the benchmark and a readme on how to run it and what the different data files from the legacy implementation are. It also includes the script used to make the dNdz's that were passed to the legacy file. This addresses Issue #5
This PR also fixes a bug where the square of the average sigma crit inverse was being used in a couple places where it should have been the average of the square (averages over the lens / source redshift distribution). This addresses Issue #42